Use handled_list to get Cinder backups for all accessible tenants #17157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
mansam
force-pushed
the
get-backups-for-all-available-tenants
branch
from
4af9698 to
6007dcd
Compare
|
Checked commit mansam@6007dcd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Was rebased by Sam and looks good to me 👍 @miq-bot rm_label unmergeable |
|
Can someone review and merge this as it relates to a blocker issue. |
|
@miq-bot add_label blocker |
|
@mansam Can this be |
|
@simaishi Yes. Once the gaprindashvili version of this is merged, I'll create a new pull request on the openstack provider repo with updated VCRs that will need to be merged to go with it. |
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 12, 2018
…enants Use handled_list to get Cinder backups for all accessible tenants (cherry picked from commit f10ac92) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566563
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cinder refresh parser should use
handled_listto collect backups so that they are collected for all accessible tenants and not just the ones that the default tenant sees. This brings backups into line with the way that volumes and snapshots are collected.This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1552129