Add rates to chargeback report #17142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
gtanzillo
reviewed
Mar 13, 2018
| @@ -22,6 +22,10 @@ class ChargebackContainerImage < Chargeback | |||
| :total_cost => :float, | |||
| ) | |||
|
|
|||
| def self.refresh_dynamic_metric_columns | |||
There was a problem hiding this comment.
This method should be put in the base model and removed from here and the container project model.
lpichler
force-pushed
the
add_rates_chargeback_report
branch
from
a66d505 to
b73e266
Compare
|
Checked commits lpichler/manageiq@17d2348~...b73e266 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on recent research, I consider beneficial to expose amounts of rates in chargeback report for each metric. It will make clearer chargeback calculations in reports.
Such rate columns are offer-able as a normal column in available columns in report definition.
Form of displaying, for example:
screen shot.
Links
@miq-bot add_label chargeback, enhancement
@miq-bot assign @gtanzillo