Support for hidden columns in reports and views

[gtanzillo]

Columns, including headers, with MiqReport#col_options[<column_name>][:hidden] == true should not
are included in html, pdf, text output formats and only be included in csv

UI changes in ManageIQ/manageiq-ui-classic#3564

/cc @dclarizio

[gmcculloug]

You do not need the array as the last line in the block when using each_with_object. This line can be removed.

[gtanzillo]

@gmcculloug I was going to remove that but then I realized that if the column is not hidden, the last line in the block would be nil. Not sure if that's correct. I'll need to try it. Thanks.

[bzwei]

@miq-bot add_label transformation

[gmcculloug]

I was able to validate this PR by added the following changes in the ui-classic repo.

--- a/product/views/VmOrTemplate.yaml
+++ b/product/views/VmOrTemplate.yaml
@@ -27,6 +27,12 @@ cols:
 - allocated_disk_storage
 - last_scan_on
 - region_description
+- uid_ems
+
+col_options:
+  uid_ems:
+    :hidden: true
+
 
 # Included tables (joined, has_one, has_many) and columns
 include:
@@ -75,6 +81,7 @@ headers:
 - Allocated Size
 - Last Analysis Time
 - Region
+- uid_ems

[miq-bot]

Checked commits gtanzillo/manageiq@7b22d8f~...eb3e0b0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

[gtanzillo]

@gmcculloug This should be good to go

[simaishi]

@gtanzillo Please add BZ link.

Edit: never mind... it's for v2v.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 0a950abc0a2fefadf4b52aa7e09b9e1a2ab7ea56
Author: Greg McCullough <[email protected]>
Date:   Tue Mar 20 10:35:36 2018 -0400

    Merge pull request #17133 from gtanzillo/report-hidden-cols
    
    Support for hidden columns in reports and views
    (cherry picked from commit 220677511a07ad56f4587133269c62a3ecde3c98)