Do not divide recipients to subgroup when sending attached report #17132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BinaryBlob table. So, after dividing recipients sending e-mail will work only for first group of resipient, attempt to send attached report for second group will throw [Couldn't find BinaryBlob...] error. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1547846
yrudman
changed the title
|
Checked commits yrudman/manageiq@4cd90e1~...258174f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add-label fine/yes, gaprindashvili/yes |
|
@miq-bot assign @gtanzillo |
|
@yrudman unrecognized command 'assigne', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
gtanzillo
approved these changes
Mar 12, 2018
yrudman
deleted the
do-not-group-recepients-to-subgroup-when-sending-attached-report
branch
simaishi
pushed a commit
that referenced
this pull request
Mar 12, 2018
…group-when-sending-attached-report Do not divide recipients to subgroup when sending attached report (cherry picked from commit 22652d9) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1554532
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 9, 2018
…group-when-sending-attached-report Do not divide recipients to subgroup when sending attached report (cherry picked from commit 22652d9) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1554533
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…s-to-subgroup-when-sending-attached-report Do not divide recipients to subgroup when sending attached report (cherry picked from commit 22652d9) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1554533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When sending report by e-mail If list if recipients is long (more than some customizable value), we are dividing recipients to sub-groups and sending separate e-mails(with attached report) to each sub-group.
It works fine for the first subgroup. Attempt to send report to second group will throw
[Couldn't find BinaryBlob with 'id'=...]error, since we are deleting record in BinaryBlob table after report was sent.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1547846
Solution:
Do not divide recipients to subgroups.
It looks like it is OK now to have list of recipients longer than 150 bytes
@miq-bot add-label bug, reporting
\cc @gtanzillo