Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagging feature for Ansible Playbooks #17099

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Add tagging feature for Ansible Playbooks #17099

merged 1 commit into from
Mar 12, 2018

Conversation

hstastna
Copy link

@hstastna hstastna commented Mar 6, 2018 •
edited
Loading

More in: https://bugzilla.redhat.com/show_bug.cgi?id=1526218
UI PR: ManageIQ/manageiq-ui-classic#3522

This PR is a part of work, with another one PR in UI repo (link above), completes adding tagging support for Ansible Playbooks (in Automation > Ansible > Playbooks). It needs to be merged first (before the UI, to remain everything work properly).

@hstastna
Copy link
Author

hstastna commented Mar 6, 2018

@miq-bot add_label blocker, enhancement, gaprindashvili/yes

@hstastna hstastna changed the title Add tagging feature for Ansible Playbooks [WIP] Add tagging feature for Ansible Playbooks Mar 6, 2018
@hstastna hstastna mentioned this pull request Mar 7, 2018
Merged
@hstastna hstastna changed the title [WIP] Add tagging feature for Ansible Playbooks Add tagging feature for Ansible Playbooks Mar 7, 2018
@miq-bot miq-bot removed the wip label Mar 7, 2018
@hstastna
Copy link
Author

hstastna commented Mar 9, 2018

@h-kataria @martinpovolny Could anyone of you review this PR? The PR is an important part of making tagging support work in Ansible Playbooks (the UI part also already done). Thanks! 👍

@hstastna
Copy link
Author

@h-kataria @martinpovolny I would like just to remain that this PR should be merged before merging the UI part of adding RBAC and tagging support. Thanks! :)

h-kataria
h-kataria reviewed Mar 12, 2018
View reviewed changes
db/fixtures/miq_product_features.yml Outdated
- :name: Edit Tags
:description: Edit Tags for the selected Ansible Playbooks
:feature_type: control
:identifier: ansible_playbook_tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hstastna should this feature also be named as all other features in this section for consistency embedded_configuration_script_payload_xxx

@hstastna hstastna force-pushed the Add_RBAC_Tagging_Ansible_Playbooks branch from d2a2a32 to 3d2b0cc Compare March 12, 2018 17:27
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commit hstastna@3d2b0cc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria
Copy link
Contributor

looks good, can be merged after Travis is green.

@h-kataria h-kataria added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 12, 2018
@h-kataria h-kataria merged commit f766292 into ManageIQ:master Mar 12, 2018
@hstastna
Copy link
Author

@simaishi The PR is ready for backporting to gaprindashvili. Thanks! 🎇

simaishi pushed a commit that referenced this pull request Mar 12, 2018
@h-kataria @simaishi
Merge pull request #17099 from hstastna/Add_RBAC_Tagging_Ansible_Play…
94c4d35 
…books

Add tagging feature for Ansible Playbooks
(cherry picked from commit f766292)

https://bugzilla.redhat.com/show_bug.cgi?id=1553768
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 94c4d358034d255380ad215bf077ff85213c575b
Author: Harpreet Kataria <[email protected]>
Date:   Mon Mar 12 15:37:00 2018 -0400

    Merge pull request #17099 from hstastna/Add_RBAC_Tagging_Ansible_Playbooks
    
    Add tagging feature for Ansible Playbooks
    (cherry picked from commit f7662924f46afacd1eae42d5cefa06c2a2abba34)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria left review comments

Assignees

@h-kataria h-kataria

Labels
blocker enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hstastna @miq-bot @h-kataria @simaishi