-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single security group in provisioning #17094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderZagaynov can you confirm for Amazon and @aufi for OpenStack? |
It's impossible to go without security group in AWS: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html#default-security-group |
@AlexanderZagaynov @agrare Ok, I will remove it then, but there is still :required: false in yaml. |
fb31b13
to
500726e
Compare
Checked commit alexander-demicev@500726e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@alexander-demichev I think you should set the |
Yeah I agree @skateman ... @AlexanderZagaynov if we should be setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works for me 👍
OpenStack doesn't require a Security Group for provisioning Instance - https://developer.openstack.org/api-ref/compute/#create-server
Thanks @alexander-demichev ! |
This PR fixes issue with selecting security groups in provisioning. Security groups are not required to perform provisioning and it is not possible to leave field empty when there was only one security group in list. Requires restarting memcached and running bin/update.
ManageIQ/manageiq-providers-openstack#178