Remove new fields from export if empty #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stay backward compatible with old importers, if the 2 new attributes options embedded_methods are empty, then we should not export it. This wold help if we try to export the Automate model from newer versions, which dont have * Embedded Methods or * Embedded Ansible methods, which use options into an older system.
|
@tinaafitz @gmcculloug @lfu |
lfu
approved these changes
Mar 5, 2018
gmcculloug
reviewed
Mar 5, 2018
spec/models/miq_ae_method_spec.rb
Outdated
| expect(result['name']).to eql('foo_method') | ||
| expect(result['location']).to eql('inline') | ||
| expect(result['options']).to be_nil | ||
| expect(result['embedded_methods']).to be_nil |
There was a problem hiding this comment.
We should check that the result hash does not have to key instead of the accessor method returning nil.
|
Checked commits mkanoor/manageiq@4ee8834~...a4156e5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mkanoor Please add BZ link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay backward compatible with old importers, if the 2 new attributes from G release
are empty, then we should not export it. This would help if we try
to export the Automate model from newer versions, which dont have
into an older system. The old importer wouldn't be aware of these new attributes.
Issue found when back porting fixes to Fine release PR # ManageIQ/manageiq-content#256