Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagging feature for Ansible Credentials #17079

Merged

Conversation

hstastna
Copy link

@hstastna hstastna commented Mar 2, 2018

More in: https://bugzilla.redhat.com/show_bug.cgi?id=1526219
UI PR: ManageIQ/manageiq-ui-classic#3507

This PR is a part of making tagging support work in Ansible Credentials, and also with another PR in UI repo (link above), completes adding tagging support for Ansible Credentials (in Automation > Ansible > Credentials). It needs to be merged first (before the UI, to remain everything work properly).

@hstastna
Copy link
Author

hstastna commented Mar 2, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Mar 2, 2018
@hstastna
Copy link
Author

hstastna commented Mar 2, 2018

@miq-bot add_label gaprindashvili/yes

@hstastna hstastna force-pushed the Add_RBAC_Tagging_Ansible_Credentials branch from 4d2cfe3 to e06ee90 Compare March 5, 2018 15:39
@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2018

Checked commit hstastna@e06ee90 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@h-kataria h-kataria added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 5, 2018
@h-kataria h-kataria merged commit e55ac98 into ManageIQ:master Mar 5, 2018
@hstastna
Copy link
Author

hstastna commented Mar 6, 2018

UI PR: ManageIQ/manageiq-ui-classic#3507

simaishi pushed a commit that referenced this pull request Mar 9, 2018
…entials

Add tagging feature for Ansible Credentials
(cherry picked from commit e55ac98)

https://bugzilla.redhat.com/show_bug.cgi?id=1553393
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit fd3979c20e0e8a320e6e7177a7b45c6bbd420576
Author: Harpreet Kataria <[email protected]>
Date:   Mon Mar 5 17:06:52 2018 -0500

    Merge pull request #17079 from hstastna/Add_RBAC_Tagging_Ansible_Credentials
    
    Add tagging feature for Ansible Credentials
    (cherry picked from commit e55ac98b6dd1dbb6bb09de48e8ef513ffab73b18)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants