Backend enhancements for transformation plan request to better support UI #17071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it does not show on the service requests screen
|
@miq-bot add_label transformation, enhancement |
bzwei
force-pushed
the
v2v_request_desc
branch
from
955ef67 to
ba8d622
Compare
|
@bzwei Looks good. |
bzwei
commented
Feb 28, 2018
| @@ -3,8 +3,13 @@ def self.base_model | |||
| ServiceTemplateTransformationPlanTask | |||
| end | |||
|
|
|||
| def self.get_description(req_obj) | |||
There was a problem hiding this comment.
I followed the example in parent class' implementation
|
Checked commits bzwei/manageiq@fbfaeec~...ba8d622 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/miq_request.rb
|
simaishi
pushed a commit
that referenced
this pull request
May 31, 2018
Backend enhancements for transformation plan request to better support UI (cherry picked from commit b253433)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small enhancements to transformation plan request
ServiceTemplateTransformationPlanRequestas backend only so that it does not show on the service requests screen