Core changes for azure targeted refresh #17070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not change passed extra attributes, since that could affect another inventory collections
Correct targeted_arel joined with load_balancer. For AWS, it was ok to join to pool, which had the same ems_ref as lb. But for Azure, the pool has different ems_ref, so we need to correctly join every table to load_balancers table and filter there Partially fixes https://bugzilla.redhat.com/show_bug.cgi?id=1487602
Ladas
changed the title
|
Checked commits Ladas/manageiq@431dd0e~...55c7163 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/load_balancer_pool.rb
app/models/manager_refresh/inventory_collection_default/network_manager.rb
|
Ladas
changed the title
agrare
approved these changes
Mar 1, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 19, 2018
…refresh Core changes for azure targeted refresh (cherry picked from commit 08aaead) https://bugzilla.redhat.com/show_bug.cgi?id=1558078
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct targeted_arel joined with load_balancer
Correct targeted_arel joined with load_balancer. For AWS,it was ok to join to pool, which had the same ems_ref as lb. But for Azure, the pool has different ems_ref, so we need to correctly join every table to load_balancers table and filter there
And do not write into extra attributes, since that can leak into other settings.
Partially fixes
https://bugzilla.redhat.com/show_bug.cgi?id=1487602
Passes all specs for all Providers locally