Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure server settings cleanup #17059

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Configure server settings cleanup #17059

merged 2 commits into from
Feb 28, 2018

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Feb 27, 2018 •
edited
Loading

https://bugzilla.redhat.com/show_bug.cgi?id=1550157

Followup to #17039

  • Load Rails after parsing ARGS for faster feedback
  • Vertically align banner examples (whitespace)

@jrafanie
Load Rails after parsing ARGS for faster feedback.
94e3d43 
We should load bundler/setup first though to ensure we're using the
bundle.
@jrafanie
Vertically align banner examples.
29e49af
@jrafanie
Copy link
Member Author

cc @rvalente

rvalente
rvalente approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@rvalente rvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tweaks 👍

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commits jrafanie/manageiq@94e3d43~...29e49af with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@bdunne bdunne merged commit cb2642a into ManageIQ:master Feb 28, 2018
@bdunne bdunne self-assigned this Feb 28, 2018
@bdunne bdunne added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
@jrafanie jrafanie deleted the configure_server_settings_cleanup branch February 28, 2018 17:04
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@bdunne @simaishi
Merge pull request #17059 from jrafanie/configure_server_settings_cle…
189697b 
…anup

Configure server settings cleanup
(cherry picked from commit cb2642a)

https://bugzilla.redhat.com/show_bug.cgi?id=1552804
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 189697b4da2c767c2ae8a1d3a3fc8ac7a754211c
Author: Brandon Dunne <[email protected]>
Date:   Wed Feb 28 10:33:05 2018 -0500

    Merge pull request #17059 from jrafanie/configure_server_settings_cleanup
    
    Configure server settings cleanup
    (cherry picked from commit cb2642a9f452d7a796bc7bdc4d3d4ddced21ef27)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@rvalente rvalente rvalente approved these changes

Assignees

@bdunne bdunne

Labels
gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrafanie @miq-bot @simaishi @rvalente @bdunne