Enhance logging around remove snapshot operations

[agrare]

Prior to removing a snapshot log the id, uid_ems, ems_ref, name, and
description to aid in diagnosing errors.

Related:

• Enhance logging around snapshot create/delete vmware_web_service#34
• Enhance logging around snapshot create/delete manageiq-smartstate#56

https://bugzilla.redhat.com/show_bug.cgi?id=1549299
https://bugzilla.redhat.com/show_bug.cgi?id=1559516

[miq-bot]

Checked commit agrare@a475155 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[rvalente]

👍

[agrare]

With these three PRs in place we will see:
Smartstate creating/deleting a snapshot:

INFO -- : Q-task_id([job_dispatcher]) VolMgrPlatformSupportLinux.preMount: VM snapshot [24-snapshot-11] created in [3.237410764] seconds
INFO -- : Q-task_id([job_dispatcher]) VolMgrPlatformSupportLinux.postMount: VM snapshot [24-snapshot-11] removed

Any vm_remove_snapshot operation (e.g. remove_unused_evm_snapshots):

INFO -- : MIQ(ManageIQ::Providers::Vmware::InfraManager::Vm#raw_remove_snapshot) removing snapshot ID: [19] uid_ems: [2018-02-27T09:25:34.82338Z] ems_ref: [snapshot-913] name: [EvmSnapshot] description [Evm Snapshot]

And at the VimBroker level we log the exact options that will be passed to vSphere for CreateSnapshot_Task and RemoveSnapshot_Task:

MiqVimVm::createSnapshot: snMor = 24-snapshot-11
MiqVimVm::removeSnapshot(24-snapshot-11, false)
MiqVimVm(host1, root).removeSnapshot: calling removeSnapshot_Task: snMor [24-snapshot-11] subtree [false]
MiqVimVm(host1, root).removeSnapshot: returned from removeSnapshot_Task: snMor [24-snapshot-11]

[simaishi]

Fine backport details:

$ git log -1
commit db8959cb6bea8dd5d9536584b0f0be0b8b9e2391
Author: Richard Oliveri <[email protected]>
Date:   Tue Feb 27 14:22:09 2018 -0500

    Merge pull request #17057 from agrare/remove_snapshot_logging
    
    Enhance logging around remove snapshot operations
    (cherry picked from commit 071270aaf87f4bcb0ab6d4ef7a57a50e5b8ee347)

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 41cc37fd318378fe76e7f6ac3b3c72383eaa1f89
Author: Richard Oliveri <[email protected]>
Date:   Tue Feb 27 14:22:09 2018 -0500

    Merge pull request #17057 from agrare/remove_snapshot_logging
    
    Enhance logging around remove snapshot operations
    (cherry picked from commit 071270aaf87f4bcb0ab6d4ef7a57a50e5b8ee347)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559546