Fix rake evm:status and evm:status_full

[NickLaMuro]

After a botched rebase (allegedly), the evm status commands became unusable since the scope for the mb_usage and mb_threshold was in the incorrect block.

This fixes that, as well as adds some tests to make this quicker to catch instead of letting our users find out for themselves.

Links

• Offending PR: Display thresholds in evm_status for workers #17016

Steps for Testing/QA

Confirm we aren't crazy by trying to run rake evm:status on master, then checkout these changes and do the same.

[NickLaMuro]

cc/ @kbrock @Fryguy @carbonin

[NickLaMuro]

@miq-bot add_label bug

[kbrock]

thnx nick

[NickLaMuro]

SCREW YOU @miq-bot ! I KNOW WHAT LOOKS GOOD!!1! ❗️ ❗️

On a more serious note, unsure why the factories seem to work differently on my machine and are causing discrepancies in the output, but will look into it. Correction/update: I was reading the test output incorrectly, it was a spacing issue, not missing data.

[NickLaMuro]

Okay, made the testing for this less brittle, so travis should now pass 😓.

---

These tests #Suck™, and it sucks that I am testing what gets sent to STDOUT/puts, and REALLY don't want to use tableize to test the output of tableize (though, I would suspect that would look ugly too...).

Anyway, my plan is to make evm_application.rb more easily testible in a future PR, so I would say for this PR, either we keep these tests for good measure, or we just take the bug fix and I make the testing happen when I refactor evm_application.rb in the future™.

[kbrock]

@NickLaMuro the width of the columns are variable based upon the input.

If you want to avoid tabelize (which does have tests by the way) I'd use "%*s" e.g.:

strs.map { |str| "%-*s" % [strs.map(&:length).max, str] }

[NickLaMuro]

@kbrock right, I realized the variable width of the columns after I started looking into it "for real-sies".

If you want to avoid tabelize (which does have tests by the way)

yeah, I figured. Mostly wanted someone to see the heredocs and be like "oh, okay, that is what it is supposed to look like". Ideally, the methods that provide the data to tableize, and the methods that call them would be separate, so you could just test the data gathers for accuracy and compare arrays.

Didn't want to do that refactoring as part of this PR, but now thinking that adding the tests is just too brittle...

[miq-bot]

Some comments on commit NickLaMuro@5b40504

spec/lib/tasks/evm_application_spec.rb

• ⚠️ - 102 - Detected puts. Remove all debugging statements.
• ⚠️ - 103 - Detected puts. Remove all debugging statements.
• ⚠️ - 51 - Detected puts. Remove all debugging statements.
• ⚠️ - 52 - Detected puts. Remove all debugging statements.
• ⚠️ - 69 - Detected puts. Remove all debugging statements.
• ⚠️ - 70 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commit NickLaMuro@5b40504 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 43 offenses detected

spec/lib/tasks/evm_application_spec.rb

• ❗ - Line 23, Col 11 - Performance/StringReplacement - Use tr instead of gsub.
• ❗ - Line 36, Col 87 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.
• ❗ - Line 58, Col 78 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 59, Col 14 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 59, Col 78 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 60, Col 121 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 60, Col 14 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 60, Col 144 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 60, Col 159 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 60, Col 41 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 60, Col 47 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 60, Col 57 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 63, Col 104 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 63, Col 44 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 63, Col 70 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 64, Col 104 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 64, Col 44 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 64, Col 70 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 65, Col 44 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 65, Col 70 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 88, Col 78 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 89, Col 14 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 89, Col 78 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 90, Col 122 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 90, Col 14 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 90, Col 145 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 90, Col 47 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 90, Col 78 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 91, Col 14 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 91, Col 145 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 91, Col 47 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 94, Col 100 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 94, Col 135 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 94, Col 73 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 95, Col 100 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 95, Col 135 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 95, Col 73 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 96, Col 100 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 96, Col 135 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 96, Col 73 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 97, Col 100 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 97, Col 135 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.
• ❗ - Line 97, Col 73 - Layout/SpaceInsideStringInterpolation - Space inside string interpolation detected.