-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence replicator spec puts #17053
Silence replicator spec puts #17053
Conversation
a574050
to
6bdec50
Compare
updated to use rspec's `expect {}.to output(message).to_stdout |
Replicating from server id=#{miq_server.id}, path=k1/k2 to 1 servers | ||
Settings: {:k1=>{:k2=>{:k3=>"v3"}}} | ||
Done | ||
MESSAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squiggly heredoc is Ruby 2.3+ (supported), so prefer <<~
instead of strip_heredoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NickLaMuro requests changes to this pull request review
This should be a rubocop rule change, and not something that should be enforced by code reviewers. If you are making suggestions like this, you should be putting this up for review in the guides repo for our standard rubocop rule set, and not here.
6bdec50
to
a57aeac
Compare
Checked commit kbrock@a57aeac with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
I hadn't seen #16023 - which attempted to hide these messages as well. updated the code to use different type of heredoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like all suggestions have been applied. Merging. |
Introduced in #15990
This no longer outputs messages into the test output, and puts the messages under test
before:
after: