Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence replicator spec puts #17053

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 26, 2018

Introduced in #15990

This no longer outputs messages into the test output, and puts the messages under test

before:

...............................Replicating from server id=97000000000140, path=k1/k2 to 1 servers
Settings: {:k1=>{:k2=>{:k3=>"v3"}}}
Done
.....

after:

....................................

@kbrock kbrock added the test label Feb 26, 2018
@kbrock kbrock requested a review from jameswnl February 26, 2018 21:30
@kbrock kbrock force-pushed the spec_replicate_messages branch from a574050 to 6bdec50 Compare February 27, 2018 17:17
@kbrock
Copy link
Member Author

kbrock commented Feb 27, 2018

updated to use rspec's `expect {}.to output(message).to_stdout

Replicating from server id=#{miq_server.id}, path=k1/k2 to 1 servers
Settings: {:k1=>{:k2=>{:k3=>"v3"}}}
Done
MESSAGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squiggly heredoc is Ruby 2.3+ (supported), so prefer <<~ instead of strip_heredoc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NickLaMuro requests changes to this pull request review

This should be a rubocop rule change, and not something that should be enforced by code reviewers. If you are making suggestions like this, you should be putting this up for review in the guides repo for our standard rubocop rule set, and not here.

@kbrock kbrock force-pushed the spec_replicate_messages branch from 6bdec50 to a57aeac Compare February 28, 2018 15:00
@miq-bot
Copy link
Member

miq-bot commented Feb 28, 2018

Checked commit kbrock@a57aeac with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@kbrock
Copy link
Member Author

kbrock commented Feb 28, 2018

I hadn't seen #16023 - which attempted to hide these messages as well.

updated the code to use different type of heredoc

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrafanie
Copy link
Member

Looks like all suggestions have been applied. Merging.

@jrafanie jrafanie merged commit 0361ee0 into ManageIQ:master Feb 28, 2018
@jrafanie jrafanie added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 28, 2018
@jrafanie jrafanie self-assigned this Feb 28, 2018
@kbrock kbrock deleted the spec_replicate_messages branch March 1, 2018 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants