configure_server_settings loses integer values #17043
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although, we do special handling of "100.megabytes" strings, etc. later
when consuming the settings such as in worker_settings using
to_i_with_method, it makes sense to check for integers here at the point
in which the user provides them so we can store them "correctly".
Note, one could argue we should handle floats or other datatypes but
99.9% of our settings are strings or integers.
http://talk.manageiq.org/t/tune-workers-via-cli/3107/4452dd84
Before the fix
After