Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname to Vm #17005

Closed
wants to merge 1 commit into from
Closed

Add hostname to Vm #17005

wants to merge 1 commit into from

Conversation

sasoc
Copy link
Contributor

@sasoc sasoc commented Feb 15, 2018

This migration adds attribute hostname to Vm. For example
virtual machine in Vmware provider has attribute computer name
and now we will be able to render it into hostname.

This migration adds attribute `hostname` to `Vm`. For example
virtual machine in Vmware provider has attribute computer name
and now we will be able to render it into hostname.
@sasoc
Copy link
Contributor Author

sasoc commented Feb 15, 2018

cc @miha-plesko

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit sasoc@a50c34c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@miha-plesko
Copy link
Contributor

Thanks @sasoc. @agrare this is the first PR to introduce hostname on VM model, as discussed yesterday on gitter. It appears the db/schema.yml file has been removed, therefore we only had to update the db/schema.rb - or did we miss something?

I kindly ask for a review.

@miq-bot assign @agrare
@miq-bot add_label enhancement

/cc @Ladas

@Ladas
Copy link
Contributor

Ladas commented Feb 15, 2018

@miha-plesko you have to send the PR in https://github.com/ManageIQ/manageiq-schema

@sasoc
Copy link
Contributor Author

sasoc commented Feb 15, 2018

@miha-plesko @Ladas I've made new PR(ManageIQ/manageiq-schema#168) in manageiq-schema and I'm closing this one.

@sasoc sasoc closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants