Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miq_product_features to miq_group #17003

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Feb 15, 2018

This adds miq_product_features to miq_group. This is needed for both ManageIQ/manageiq-api#311 as well as to expose the miq_groups via the api such as /api/groups/:id?attributes=miq_product_features

@miq-bot assign @gtanzillo
cc: @abellotti

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit jntullo@b756550 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/models/miq_group.rb

@abellotti
Copy link
Member

LGTM!! Thanks @jntullo 👍 just tried this from the API.

@abellotti abellotti self-requested a review February 15, 2018 14:53
@gtanzillo gtanzillo added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 15, 2018
@gtanzillo gtanzillo merged commit c7d99c9 into ManageIQ:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants