Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-check the provider authentication if the API is responding #16989

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Re-check the provider authentication if the API is responding #16989

merged 1 commit into from
Feb 12, 2018

Conversation

carbonin
Copy link
Member

This fixes an issue where we hit a race condition when the ansible API is not ready yet, but is technically "alive".

Before we would see that it was alive, but would never re-check the credentials so we would never get refresh workers.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539782

@carbonin
Re-check the provider authentication if the API is responding
6e57b51 
This fixes an issue where we hit a race condition when
the ansible API is not ready yet, but is technically "alive".

Before we would see that it was alive, but would never re-check
the credentials so we would never get refresh workers.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539782
jrafanie
jrafanie approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@Mig-Bot merge_when_green 🤣

@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2018

Checked commit carbonin@6e57b51 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@jrafanie jrafanie merged commit 04aea3e into ManageIQ:master Feb 12, 2018
@jrafanie jrafanie added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 12, 2018
@carbonin carbonin deleted the recheck_embedded_ansible_authentication branch February 19, 2018 21:39
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@jrafanie @simaishi
Merge pull request #16989 from carbonin/recheck_embedded_ansible_auth…
a2d7cf1 
…entication

Re-check the provider authentication if the API is responding
(cherry picked from commit 04aea3e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552783
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit a2d7cf136f437fa54f4716521cc40c932fd049f1
Author: Joe Rafaniello <[email protected]>
Date:   Mon Feb 12 16:45:41 2018 -0500

    Merge pull request #16989 from carbonin/recheck_embedded_ansible_authentication
    
    Re-check the provider authentication if the API is responding
    (cherry picked from commit 04aea3efbeebb44487c34e1c760314ea8b963532)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
bug core/workers gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carbonin @miq-bot @simaishi @jrafanie