Fix for differing behavior in DialogFieldTagControl multi/single drop downs #16955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@d1d5161 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/dialog_field_serializer_spec.rb
|
|
👍 |
d-m-u
approved these changes
Feb 6, 2018
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2018
Fix for differing behavior in DialogFieldTagControl multi/single drop downs (cherry picked from commit e07ecd0) https://bugzilla.redhat.com/show_bug.cgi?id=1542610
|
Gaprindashvili backport details: |
d-m-u
added a commit
to d-m-u/manageiq
that referenced
this pull request
May 9, 2018
d-m-u
added a commit
to d-m-u/manageiq
that referenced
this pull request
May 9, 2018
d-m-u
added a commit
to d-m-u/manageiq
that referenced
this pull request
May 9, 2018
d-m-u
added a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that any data coming back from the API serializes the
force_single_valuecorrectly since the value should not simply take into account how it is set on the dialog but also if the category that is selected is a single value category.This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1540273 and was found during testing of it.
@miq-bot add_label gaprindashvili/yes, bug, blocker
@miq-bot assign @gmcculloug