Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename when downloading pdf from Flavor summary #16944

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

bmclaughlin
Copy link
Contributor

Filename before:
ManageIQ_Providers_Openstack_Cloud Manager_Flavor_m1.large_summary_2018_02_02.pdf

Filename after:
Flavor (OpenStack)_m1.large_summary_2018_02_02.pdf

@miq-bot add_labels providers/cloud, bug, blocker

https://bugzilla.redhat.com/show_bug.cgi?id=1540601

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2018

Checked commit bmclaughlin@5dc0375 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@bdunne bdunne merged commit 74e132d into ManageIQ:master Feb 2, 2018
@bdunne bdunne added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 2, 2018
@bdunne bdunne self-assigned this Feb 2, 2018
@bmclaughlin bmclaughlin deleted the add-missing-flavor-string branch February 5, 2018 13:34
@simaishi
Copy link
Contributor

@bmclaughlin Can this be gaprindashvili/yes and fine/yes?

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_labels gaprindashvili/yes, fine/yes

simaishi pushed a commit that referenced this pull request Apr 18, 2018
Fix filename when downloading pdf from Flavor summary
(cherry picked from commit 74e132d)

https://bugzilla.redhat.com/show_bug.cgi?id=1569237
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 073a0c4aef11aaede3867ea1dfe16d8fa5fc404f
Author: Brandon Dunne <[email protected]>
Date:   Fri Feb 2 16:38:11 2018 -0500

    Merge pull request #16944 from bmclaughlin/add-missing-flavor-string
    
    Fix filename when downloading pdf from Flavor summary
    (cherry picked from commit 74e132dab2284a5d0fe3ab252b80ee6c54e94a66)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1569237

simaishi pushed a commit that referenced this pull request Apr 18, 2018
Fix filename when downloading pdf from Flavor summary
(cherry picked from commit 74e132d)

https://bugzilla.redhat.com/show_bug.cgi?id=1569236
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cab2891b07c2ed56f945cfe1689518fc8f36cac2
Author: Brandon Dunne <[email protected]>
Date:   Fri Feb 2 16:38:11 2018 -0500

    Merge pull request #16944 from bmclaughlin/add-missing-flavor-string
    
    Fix filename when downloading pdf from Flavor summary
    (cherry picked from commit 74e132dab2284a5d0fe3ab252b80ee6c54e94a66)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1569236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants