Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to spawn instead of fork a worker #16943

Closed
wants to merge 1 commit into from
Closed

Add setting to spawn instead of fork a worker #16943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/models/miq_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,11 @@ def queue_name
end

def start_runner
if ENV['MIQ_SPAWN_WORKERS'] || !Process.respond_to?(:fork)
start_runner_via_spawn
else
start_runner_via_fork
end
spawn_worker? ? start_runner_via_spawn : start_runner_via_fork
end

def spawn_worker?
ENV['MIQ_SPAWN_WORKERS'] || !Process.respond_to?(:fork) || worker_settings[:spawn_worker]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare Why do we need a setting for this? Does the ENV variable not work? I'm not sure the "why" here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping this would give us a way to control this on fine release, I wasn't aware of a way to change the env vars per worker type on that release but if it exists then great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real "why" is to spawn not fork VMware provider workers on a fine appliance to see if it solves the drb errors connecting with the broker

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare Pretty sure this SPAWN_WORKERS isn't available on fine:

https://github.com/ManageIQ/manageiq/blob/fine/app/models/miq_worker.rb

So you might need to do a bit of backporting if that was the end goal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes absolutely I was planning on needing to backport some of @jrafanie 's changes to make this an option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmk, you will absolute need this then as well:

https://github.com/ManageIQ/manageiq/blob/master/lib/workers/bin/run_single_worker.rb

And there are a few PRs surrounding that as well that would need to be backported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I have a hard time believing this would work without a significant amount of work to backport changes. The main problem is the forked workers inherit all of the booted code, $LOADED_FEATURES, so if we go spawn, we have to ensure anything that wasn't loaded in the spawned workers, we'd need to make it load as part of the boot of the spawned workers.

end

def start_runner_via_fork
Expand Down
2 changes: 2 additions & 0 deletions config/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,7 @@
:poll_escalate_max: 30.seconds
:poll_method: :normal
:restart_interval: 0.hours
:spawn_worker: false
:starting_timeout: 10.minutes
:stopping_timeout: 10.minutes
:embedded_ansible_worker:
Expand Down Expand Up @@ -1227,6 +1228,7 @@
:nice_delta: 3
:poll: 1.seconds
:reconnect_retry_interval: 5.minutes
:spawn_worker: true
:vim_broker_status_interval: 15.minutes
:vim_broker_update_interval: 0.seconds
:vim_broker_max_wait: 60
Expand Down