-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer assume that a value is an array #16924
Conversation
@miq-bot add_label bug, services cc @gmcculloug |
@miq-bot add_label blocker |
@miq-bot add_label 'gaprindashvili/yes' |
@AlonaKaplan - Pinging you on this. We found a case where |
@syncrou Cannot apply the following label because they are not recognized: 'gaprindashvili/yes' |
@miq-bot add_label gaprindashvili/yes |
I prefer Not a huge deal, but I vaguely recall smacking into this with the Azure refresh parser at some point. |
We found a situation where an ||= was failing because the result was nil as opposed to an array. Adding a .try to the lookup allows us to pass nil in these specific cases. https://bugzilla.redhat.com/show_bug.cgi?id=1540326
2cce2b9
to
698a346
Compare
Checked commit syncrou@698a346 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@syncrou LGTM 👍 Can you also add test cases? |
@lfu - I have the beginnings of a refactor with tests worked up. I was planning on a followup PR to handle them so we can close this blocker. |
@syncrou That works for me. |
No longer assume that a value is an array (cherry picked from commit 27b975a) https://bugzilla.redhat.com/show_bug.cgi?id=1541171
Gaprindashvili backport details:
|
We found a situation where an ||= was failing because the result was nil as opposed to an array.
Adding a .try to the lookup allows us to pass nil in these specific cases.
https://bugzilla.redhat.com/show_bug.cgi?id=1540326