Fix event linking to a disconnected VM

[agrare]

When linking events to a VM we first try [ems_id, ems_ref] which fails
to find a disconnected VM because the ems_id is nullified. Next we try
by uid_ems but no one was setting the field that we were using so this
standardizes on an event key :vm_uid_ems (similar to :vm_location) which
can be set by the EventParser to allow events to be connected to VMs
after they are disconnected.

Depends:

• Add VM UUID to event payload vmware_web_service#32
• Add VM uuid as the vm_uid_ems to the event payload manageiq-providers-vmware#179

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538996

[agrare]

I tried to find where we set event[:full_data][:vm][:uid_ems], it was added by @gmcculloug in 6af4509506a528b68595acb273b2fff8996216b7 (need historical_root, commit from 2009)

+  def add_vm_event(event_type, vm, data=nil)
+    event = {:vm => {:path => vm[:location], :name=>vm[:name], :uid_ems=>vm[:uid_ems]}, :data => data}

But we don't initialize event hashes like this anymore so I think it is safe to change to something more standard. If we want to be extra safe I can just do:

event.fetch_path(:full_data, :vm, :uid_ems) || event[:vm_uid_ems]

[miq-bot]

Checked commit agrare@5bea3d8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[simaishi]

gaprindashvili/yes ?

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 679eef556990e5254e415bd16e808639deb3083e
Author: Greg Blomquist <[email protected]>
Date:   Wed Feb 7 16:50:36 2018 -0500

    Merge pull request #16907 from agrare/bz_1538996_vm_destroy_event_missing
    
    Fix event linking to a disconnected VM
    (cherry picked from commit 4f0654726ad03a9dbed829d4194791e0be3117f5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552677