Rescue attempt to get backlog for remote db in PglogicalSubscription#backlog #16889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Jan 25, 2018
app/models/pglogical_subscription.rb
Outdated
| @@ -102,6 +102,9 @@ def validate(new_connection_params = {}) | |||
|
|
|||
| def backlog | |||
| connection.xlog_location_diff(remote_node_lsn, remote_replication_lsn) | |||
| rescue => e | |||
There was a problem hiding this comment.
Is there something more specific we can rescue here? Maybe a PG error of some sort?
There was a problem hiding this comment.
yeaa, I should have done it, changed.
…nage subscription screen even if remote db is offline https://bugzilla.redhat.com/show_bug.cgi?id=1533958
yrudman
force-pushed
the
rescue-attempt-to-get-backlog-for-replication
branch
from
5e16dd9 to
a9e8ee8
Compare
|
Checked commits yrudman/manageiq@f40c043~...a9e8ee8 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add-label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 1, 2018
…for-replication Rescue attempt to get backlog for remote db in PglogicalSubscription#backlog (cherry picked from commit 0e76e34) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550729
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Mar 6, 2018
…for-replication Rescue attempt to get backlog for remote db in PglogicalSubscription#backlog (cherry picked from commit 0e76e34) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550728
|
Gaprindashvili backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…backlog-for-replication Rescue attempt to get backlog for remote db in PglogicalSubscription#backlog (cherry picked from commit 0e76e34) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Replication management screen on global region throws Error when any of subscribed DB is down.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533958
@miq-bot add-label bug
\cc @carbonin