Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event state machine is added to replace the synchronous refresh. #16868

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Event state machine is added to replace the synchronous refresh. #16868

merged 1 commit into from
Jan 25, 2018

Conversation

lfu
Copy link
Member

@lfu lfu commented Jan 23, 2018 •
edited
Loading

Event state machine is added in ManageIQ/manageiq-content#243.

Blocks ManageIQ/manageiq-content#243.
https://bugzilla.redhat.com/show_bug.cgi?id=1534631

@miq-bot assign @gmcculloug
@miq-bot add_label bug, fine/yes, gaprindashvili/yes
cc @mkanoor

@lfu lfu mentioned this pull request Jan 23, 2018
Merged
@gmcculloug
Copy link
Member

@lfu Who is the caller of this method?

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2018

Checked commit lfu@31252c1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@lfu
Copy link
Member Author

lfu commented Jan 23, 2018

@gmcculloug It is event_action_refresh_sync.

@gmcculloug
Copy link
Member

That event ultimately translate to the built-in method here:
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_builtin_method.rb#L112-L114

@gmcculloug gmcculloug merged commit cac9ac7 into ManageIQ:master Jan 25, 2018
@gmcculloug gmcculloug added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 25, 2018
@lfu lfu deleted the event_action_refresh_sync_1534631 branch February 21, 2018 13:46
simaishi pushed a commit that referenced this pull request Mar 1, 2018
@gmcculloug @simaishi
Merge pull request #16868 from lfu/event_action_refresh_sync_1534631
a6941a9 
Event state machine is added to replace the synchronous refresh.
(cherry picked from commit cac9ac7)

https://bugzilla.redhat.com/show_bug.cgi?id=1550725
@simaishi
Copy link
Contributor

simaishi commented Mar 1, 2018

Fine backport details:

$ git log -1
commit a6941a9ce59c5a424570c0b6cccd13ab9717e697
Author: Greg McCullough <[email protected]>
Date:   Thu Jan 25 08:10:55 2018 -0500

    Merge pull request #16868 from lfu/event_action_refresh_sync_1534631
    
    Event state machine is added to replace the synchronous refresh.
    (cherry picked from commit cac9ac77123e8b2e83fabddab4ea66f149ea61f8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550725

simaishi pushed a commit that referenced this pull request Mar 6, 2018
@gmcculloug @simaishi
Merge pull request #16868 from lfu/event_action_refresh_sync_1534631
af41492 
Event state machine is added to replace the synchronous refresh.
(cherry picked from commit cac9ac7)

https://bugzilla.redhat.com/show_bug.cgi?id=1550724
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit af414924ef8bfb94ded9a0a19a87db8951157e7f
Author: Greg McCullough <[email protected]>
Date:   Thu Jan 25 08:10:55 2018 -0500

    Merge pull request #16868 from lfu/event_action_refresh_sync_1534631
    
    Event state machine is added to replace the synchronous refresh.
    (cherry picked from commit cac9ac77123e8b2e83fabddab4ea66f149ea61f8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550724

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
@gmcculloug @d-m-u
Merge pull request ManageIQ#16868 from lfu/event_action_refresh_sync_…
ce32f93 
…1534631

Event state machine is added to replace the synchronous refresh.
(cherry picked from commit cac9ac7)

https://bugzilla.redhat.com/show_bug.cgi?id=1550725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfu @gmcculloug @miq-bot @simaishi