-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many things rely on authentications, check it first #16864
Merged
gtanzillo
merged 1 commit into
ManageIQ:master
from
jrafanie:run_authentication_checks_at_max_priority
Jan 23, 2018
Merged
Many things rely on authentications, check it first #16864
gtanzillo
merged 1 commit into
ManageIQ:master
from
jrafanie:run_authentication_checks_at_max_priority
Jan 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
run_authentication_checks_at_max_priority
branch
from
January 22, 2018 20:14
675fbee
to
aa339de
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1534631 We can get stuck if: * Automate event processing queues refresh and waits * Refresh workers aren't running because credentials are temporarily bad * Authentication checks don't get processed because they are normal priority, which is lower than an event storm of automate messages at high priority
jrafanie
force-pushed
the
run_authentication_checks_at_max_priority
branch
from
January 22, 2018 20:17
aa339de
to
cec452e
Compare
Fryguy
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Checked commit jrafanie@cec452e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Jan 22, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 1, 2018
…max_priority Many things rely on authentications, check it first (cherry picked from commit 9915f79) https://bugzilla.redhat.com/show_bug.cgi?id=1550725
Fine backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Mar 6, 2018
…max_priority Many things rely on authentications, check it first (cherry picked from commit 9915f79) https://bugzilla.redhat.com/show_bug.cgi?id=1550724
Gaprindashvili backport details:
|
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ecks_at_max_priority Many things rely on authentications, check it first (cherry picked from commit 9915f79) https://bugzilla.redhat.com/show_bug.cgi?id=1550725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1534631
We can get stuck if:
which is lower than an event storm of automate messages at high priority