Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many things rely on authentications, check it first #16864

Merged

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jan 22, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1534631

We can get stuck if:

  • Automate event processing queues refresh and waits
  • Refresh workers aren't running because credentials are temporarily bad
  • Authentication checks don't get processed because they are normal priority,
    which is lower than an event storm of automate messages at high priority

@jrafanie jrafanie modified the milestone: Sprint 78 Ending Jan 29, 2018 Jan 22, 2018
@jrafanie jrafanie force-pushed the run_authentication_checks_at_max_priority branch from 675fbee to aa339de Compare January 22, 2018 20:14
https://bugzilla.redhat.com/show_bug.cgi?id=1534631

We can get stuck if:
* Automate event processing queues refresh and waits
* Refresh workers aren't running because credentials are temporarily bad
* Authentication checks don't get processed because they are normal priority,
which is lower than an event storm of automate messages at high priority
@jrafanie jrafanie force-pushed the run_authentication_checks_at_max_priority branch from aa339de to cec452e Compare January 22, 2018 20:17
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miq-bot
Copy link
Member

miq-bot commented Jan 22, 2018

Checked commit jrafanie@cec452e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gtanzillo gtanzillo added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 23, 2018
@gtanzillo gtanzillo merged commit 9915f79 into ManageIQ:master Jan 23, 2018
@jrafanie jrafanie deleted the run_authentication_checks_at_max_priority branch January 24, 2018 20:37
simaishi pushed a commit that referenced this pull request Mar 1, 2018
…max_priority

Many things rely on authentications, check it first
(cherry picked from commit 9915f79)

https://bugzilla.redhat.com/show_bug.cgi?id=1550725
@simaishi
Copy link
Contributor

simaishi commented Mar 1, 2018

Fine backport details:

$ git log -1
commit 6e949a7358e58311eb6fe83831251b819d09145b
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Jan 23 13:30:08 2018 -0500

    Merge pull request #16864 from jrafanie/run_authentication_checks_at_max_priority
    
    Many things rely on authentications, check it first
    (cherry picked from commit 9915f79bf8e552581f868dc5347dc93ed68d0eb8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550725

simaishi pushed a commit that referenced this pull request Mar 6, 2018
…max_priority

Many things rely on authentications, check it first
(cherry picked from commit 9915f79)

https://bugzilla.redhat.com/show_bug.cgi?id=1550724
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 07aeddf3eaddaeeb8b00be6b54b0226921956374
Author: Gregg Tanzillo <[email protected]>
Date:   Tue Jan 23 13:30:08 2018 -0500

    Merge pull request #16864 from jrafanie/run_authentication_checks_at_max_priority
    
    Many things rely on authentications, check it first
    (cherry picked from commit 9915f79bf8e552581f868dc5347dc93ed68d0eb8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1550724

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…ecks_at_max_priority

Many things rely on authentications, check it first
(cherry picked from commit 9915f79)

https://bugzilla.redhat.com/show_bug.cgi?id=1550725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants