Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing role for container user groups #16861

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Add missing role for container user groups #16861

merged 1 commit into from
Jan 21, 2018

Conversation

moolitayer
Copy link

@moolitayer moolitayer commented Jan 21, 2018 •
edited
Loading

Fix https://bugzilla.redhat.com/show_bug.cgi?id=1494963

We would like users belonging to each of these groups to have access to the monitoring screens;

  • EvmGroup-container_administrator
  • EvmGroup-container_operator

Tested this allows members of both groups to enter both monitoring screens, and add a comment in the alert list screen.

See:
Main Menu
Product Feature

elad661
elad661 approved these changes Jan 21, 2018
View reviewed changes
Copy link
Contributor

@elad661 elad661 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miq-bot
Copy link
Member

miq-bot commented Jan 21, 2018

Checked commit moolitayer@50f32df with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@moolitayer
Copy link
Author

@agrare @Fryguy @chessbyte Hopefully someone can merge this blocker ASAP, Thanks

@moolitayer
Copy link
Author

@miq-bot add_label blocker, bug, providers/containers

@moolitayer
Copy link
Author

@miq-bot add_label gaprindashvili/yes

@agrare agrare merged commit 7cdd6f0 into ManageIQ:master Jan 21, 2018
@agrare agrare self-assigned this Jan 21, 2018
@agrare agrare added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 21, 2018
simaishi pushed a commit that referenced this pull request Jan 22, 2018
@agrare @simaishi
Merge pull request #16861 from moolitayer/add_monitor_role
48bbf52 
Add missing role for container user groups
(cherry picked from commit 7cdd6f0)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537135
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 48bbf52c3207f3efe925352890420233cd24e3ab
Author: Adam Grare <[email protected]>
Date:   Sun Jan 21 16:04:19 2018 -0500

    Merge pull request #16861 from moolitayer/add_monitor_role
    
    Add missing role for container user groups
    (cherry picked from commit 7cdd6f0ee86014ac1fcd91e3777cbf0ff9e77f77)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@elad661 elad661 elad661 approved these changes

Assignees

@agrare agrare

Labels
blocker bug gaprindashvili/backported providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moolitayer @miq-bot @simaishi @elad661 @agrare