Singularize plural model

[bdunne]

The model was created as a plural, luckily the table name appears to be correct so we don't need a schema migration.

Added in #14749
Found because of #16768 (comment)

[miq-bot]

Checked commits bdunne/manageiq@4f83aa7~...e7fbe82 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 2 offenses detected

app/models/asset_detail.rb

• ❗ - Line 6, Col 3 - Rails/InverseOf - Specify an :inverse_of option.

app/models/ems_refresh/save_inventory_physical_infra.rb

• ❗ - Line 50, Col 18 - Style/SymbolArray - Use %i or %I for an array of symbols.

[Fryguy]

LOL @ the branch name

[Fryguy]

Have you verified this is not called in other repos? In particular in the Lenovo repo.

[bdunne]

I see https://github.com/ManageIQ/manageiq-providers-lenovo/blob/master/app/models/manageiq/providers/lenovo/physical_infra_manager/parsers/parser_dictionary_constants.rb#L51 but I have no idea what it is. Maybe @agrare can help?

[agrare]

Its the first time I've seen that but it looks like it uses that as the base for the parsed result hash, so yes that would need to change otherwise you'll get save_inventory errors.

[bdunne]

Okay @Fryguy I think I found all of the other repos that use this and linked the PR's here

[agrare]

👍

[blomquisg]

@rodneyhbrown7 this change might impact developers that have local uncommitted changes for any features currently in development.

[agrare]

Changing assignee to fryguy since I can't merge the ui-classic or api PRs together with this one