Add acts_as_miq_taggable to AuthPrivateKey

[syncrou]

The RBAC filtering was not 100% applied to the AuthPrivate key class which
caused tagging to fail. This change allows key_pairs to return correctly when
run through RBAC when being tagged

https://bugzilla.redhat.com/show_bug.cgi?id=1514237

[syncrou]

@miq-bot add_label wip, bug, blocker, providers

@miq-bot assign @gmcculloug

cc - @gtanzillo

[syncrou]

@gtanzillo - Would you mind taking a look at this PR. The Authentication class is already included in lib/rbac/filterer.rb CLASSES_THAT_PARTICIPATE_IN_RBAC constant, however the inclusion of acts_as_miq_taggable was not. With that change I was able to tag AuthPrivateKey instances in the specs, and the UI would filter key_pairs as expected.

[gtanzillo]

@syncrou Looks good!

[gmcculloug]

@gtanzillo If Authentication class is already included in CLASSES_THAT_PARTICIPATE_IN_RBAC does it makes sense to move the acts_as_miq_taggable to the base Authentication class or keep it in the subclass AuthPrivateKey?

[gtanzillo]

@gmcculloug

@gtanzillo If Authentication class is already included in CLASSES_THAT_PARTICIPATE_IN_RBAC does it makes sense to move the acts_as_miq_taggable to the base Authentication class or keep it in the subclass AuthPrivateKey?

I was thinking about that too but didn't see a use case for universally enabling tagging on all authentications. Like provider credentials. That said, I don't think it would hurt anything either.

[syncrou]

@gtanzillo - Thanks GT!

@miq-bot remove_label wip

[gmcculloug]

I realize this won't matter but if we are going to name the elements with a number should we give them unique names?

Maybe:

2.times do |i|
  kp = ManageIQ::Providers::CloudManager::AuthKeyPair.create(:name => "auth_#{i}")
end

You can even use i + 1 here if you don't want a zero element name. 😄

[miq-bot]

Checked commit syncrou@feadd7a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit e3e95363ef8eb12cf3937112f4c7b6e01144441d
Author: Greg McCullough <[email protected]>
Date:   Wed Jan 17 19:59:00 2018 -0500

    Merge pull request #16828 from syncrou/add_auth_private_key_to_rbac
    
    Add acts_as_miq_taggable to AuthPrivateKey
    (cherry picked from commit fad3529c00ab1797a8633bc090c964d92b244248)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1532646

[simaishi]

Fine backport details:

$ git log -1
commit bb43558c8e9f9805fecce622281c726fb8ead81d
Author: Greg McCullough <[email protected]>
Date:   Wed Jan 17 19:59:00 2018 -0500

    Merge pull request #16828 from syncrou/add_auth_private_key_to_rbac
    
    Add acts_as_miq_taggable to AuthPrivateKey
    (cherry picked from commit fad3529c00ab1797a8633bc090c964d92b244248)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1533139