Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1518279 For all roles that have sui product features adds sui_notifications #16817

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jan 12, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1518279

Those roles with sui or sui_core don't require this product feature to ensure consistent behavior.
This pr has a sister in the sui repo, these combined close thhe bz: ManageIQ/manageiq-ui-service#1293

Those roles with `sui` or `sui_core` don't require this product feature to ensure consistent behavior.
This pr has a sister in the sui repo: ManageIQ/manageiq-ui-service#1293
@AllenBW AllenBW force-pushed the #1518279-update-sui-roles-to-include-sui-notifications branch from aa4534e to 183b0ce Compare January 12, 2018 16:21
@AllenBW
Copy link
Member Author

AllenBW commented Jan 12, 2018

@miq-bot add_label gaprindashvili/yes,bug

@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2018

Checked commit AllenBW@183b0ce with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit c57a11b into ManageIQ:master Feb 24, 2018
@martinpovolny martinpovolny added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 24, 2018
@AllenBW AllenBW deleted the #1518279-update-sui-roles-to-include-sui-notifications branch February 26, 2018 12:51
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 03fe3c2a815b36822b0e8e59bc9e7ca7a0a0dc1d
Author: Martin Povolny <[email protected]>
Date:   Sat Feb 24 17:59:47 2018 +0100

    Merge pull request #16817 from AllenBW/#1518279-update-sui-roles-to-include-sui-notifications
    
    (cherry picked from commit c57a11b98aae1f89d58fe179149c9f647e001961)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants