Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1531658 Update group/role EvmGroup-desktop product features #16788

Merged
merged 1 commit into from
Jan 10, 2018
Merged

#1531658 Update group/role EvmGroup-desktop product features #16788

merged 1 commit into from
Jan 10, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Jan 10, 2018 •
edited
Loading

closes https://bugzilla.redhat.com/show_bug.cgi?id=1531658

Also rewords sui_orders_show to sui_orders_view (the correct product feature name)

@AllenBW
Rewords sui_orders_show to sui_orders_view, adds sui_services_view
587b1d5 
Role evmgroup-desktop can't utilize service product features without sui_services_view product feature
@AllenBW
Copy link
Member Author

AllenBW commented Jan 10, 2018

@miq-bot add_label gaprindashvili/yes,blocker,bug

@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2018

Checked commit AllenBW@587b1d5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio
Copy link

BZ is pending NEEDINFO response from @Loicavenel prior to merge.

@Loicavenel
Copy link

Approved

@himdel
Copy link
Contributor

himdel commented Jan 10, 2018

LGTM, sui_services_view is indeed the missing role.

Also, sui_orders_show doesn't exist in SUI, sui_services_view does 👍

@dclarizio I can't merge this, would you? :)

@dclarizio dclarizio merged commit eee8581 into ManageIQ:master Jan 10, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 10, 2018
simaishi pushed a commit that referenced this pull request Jan 10, 2018
@simaishi
Merge pull request #16788 from AllenBW/#1531658-update-evmdesktop-pro…
f8e0dd3 
…duct-features

(cherry picked from commit eee8581)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533222
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f8e0dd3b28e4a25730eb9f74633bcbe55e1a649f
Author: Dan Clarizio <[email protected]>
Date:   Wed Jan 10 08:36:32 2018 -0800

    Merge pull request #16788 from AllenBW/#1531658-update-evmdesktop-product-features
    
    (cherry picked from commit eee858120a0cc8ecbfed2ca3f1a3da0823e718d5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533222

@AllenBW AllenBW deleted the #1531658-update-evmdesktop-product-features branch February 26, 2018 13:49
@NickLaMuro NickLaMuro mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
blocker bug gaprindashvili/backported ui/service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AllenBW @miq-bot @dclarizio @Loicavenel @himdel @simaishi