Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed control explorer feature id #16780

Merged

Conversation

h-kataria
Copy link
Contributor

Fixed control explorer feature id for EvmRole-security, EvmRole-support,EvmRole-auditor, EvmRole-approver roles. This was causing confusion by not showing them as selected in the Product features tree whereas these roles did have an access to Control explorer in UI.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525598

before:
before

after:
after

Fixed control explorer feature id for EvmRole-security, EvmRole-support,EvmRole-auditor, EvmRole-approver roles. This was causing confusion by not showing them as selected in the Product features tree whereas these roles did have an access to Control explorer in UI.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525598
@h-kataria
Copy link
Contributor Author

@dclarizio please review

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

Checked commit h-kataria@827e8a8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio dclarizio added the ui label Jan 9, 2018
@dclarizio dclarizio merged commit 90052b1 into ManageIQ:master Jan 9, 2018
@dclarizio dclarizio deleted the controle_explorer_feature_access_fix branch January 9, 2018 21:39
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 9, 2018
simaishi pushed a commit that referenced this pull request Jan 10, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7632a94a980e2d617e1cb5e6d4bb718f8128f8f8
Author: Dan Clarizio <[email protected]>
Date:   Tue Jan 9 13:39:48 2018 -0800

    Merge pull request #16780 from h-kataria/controle_explorer_feature_access_fix
    
    Fixed control explorer feature id
    (cherry picked from commit 90052b1e8568e688ebe317370d3824c7c3d7ecaf)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533219

@simaishi
Copy link
Contributor

@h-kataria https://bugzilla.redhat.com/show_bug.cgi?id=1525598 is marked for 5.8.z. Can this be fine/yes?

@h-kataria
Copy link
Contributor Author

@simaishi added fine/yes flag

simaishi pushed a commit that referenced this pull request Apr 16, 2018
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 3fe4c1a7e3289f8bfb1f38ebb861a0956b0cad98
Author: Dan Clarizio <[email protected]>
Date:   Tue Jan 9 13:39:48 2018 -0800

    Merge pull request #16780 from h-kataria/controle_explorer_feature_access_fix
    
    Fixed control explorer feature id
    (cherry picked from commit 90052b1e8568e688ebe317370d3824c7c3d7ecaf)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568045

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…ature_access_fix

Fixed control explorer feature id
(cherry picked from commit 90052b1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1568045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants