Fix check_quota(:active_provisions) for Service MiqRequest invalid service_template.

[tinaafitz]

Prevent error in check_quota(:active_provisions) for Service MiqRequests with invalid service_templates.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531914

We recently changed the active_provision code to calculate quota values for Service requests by looking at the request service_template.service_resource information.
The customer supplied data showed Service requests miq_tasks queued to a zone but never dispatched, it appears the Zone or automate role for the zone was disabled. This made the Service requests look like they were active, but were not being processed. Then the service_template for which the Service request was created was deleted causing the Service request to have an invalid service_template relationship.

Although the issue impacts any calls to the check_quota(:active_provisions) method, the customer encountered it in the request.check_quota(:active_provisions) call here:
RedHat Automate domain method:
/Infrastructure/VM/Provisioning/Placement/vmware_best_fit_with_scope
Since the vmware_best_fit_with_scope method is used during VM Provisioning, all provisions would fail if the active_quota calculations encountered a single Service MiqRequest with an invalid service_template, even if Quota is not being used.

[tinaafitz]

@miq_bot add_label bug, provisioning, services, gaprindashvili/yes

[miq-bot]

Checked commit tinaafitz@0d6e974 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[tinaafitz]

@miq-bot assign @gmcculloug

[gmcculloug]

@tinaafitz In the description It makes more sense to focus on the call to check_quota(:active_provisions) instead of the locations that it is being called from. The issue would impact any call to that method and is not directly related to where it is being called from. It does makes sense to reference where the call was as it explains why the provision task raised the error in this case, but again the best-fit method is not the main cause of the issue.

Also, some more background on the error condition (Service MiqRequest with an invalid service_template) would be useful for someone viewing this PR in the future.

By which I mean, we determined that tasks were queued to a zone but never dispatched, it appears the Zone or automate role for the zone was disabled. This made the requests look like they were active, but were not being processed. Then the service_template for which the request was created was deleted causing the request to have an invalid service_template relationship.

[tinaafitz]

@gmcculloug Thank you for the feedback. I've updated the PR description with more detail. Please let me know if there's anything else you'd like me change.

[gmcculloug]

Does load_queue only queue ServiceTemplateProvisionRequest instances? In other words, are you sure this first request will by a ServiceTemplateProvisionRequest and therefore expect to have a service_template relationship?

[tinaafitz]

@gmcculloug Yes, I am sure the first request will be a ServiceTemplateProvisionRequest since load_queue only queues ServiceTemplateProvisionRequest instances.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 9b58a4a4dc2a0bc90849c432584e0a22b2d07513
Author: Greg McCullough <[email protected]>
Date:   Tue Jan 9 15:30:37 2018 -0500

    Merge pull request #16769 from tinaafitz/quota_mixin_service_template_fix
    
    Fix check_quota(:active_provisions) for Service MiqRequest invalid service_template.
    (cherry picked from commit 8aa881f53bfa3ae2517921bbd061d82d01ccd600)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533217

[simaishi]

Fine backport details:

$ git log -1
commit 7de622587cc1a162178b6ccf9d78f2188522d3f9
Author: Greg McCullough <[email protected]>
Date:   Tue Jan 9 15:30:37 2018 -0500

    Merge pull request #16769 from tinaafitz/quota_mixin_service_template_fix
    
    Fix check_quota(:active_provisions) for Service MiqRequest invalid service_template.
    (cherry picked from commit 8aa881f53bfa3ae2517921bbd061d82d01ccd600)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1534589