Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect host on provider add #16767

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

pkliczewski
Copy link
Contributor

Persister expect all the methods to define collection attributes when
performin targeted refresh so moving the lambda.

Fixes https://bugzilla.redhat.com/1528859

Persister expect all the methods to define collection attributes when
performin targeted refresh so moving the lambda.

Fixes https://bugzilla.redhat.com/1528859
@pkliczewski
Copy link
Contributor Author

@Ladas @agrare please review. Here is the code which do not like the method.

@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2018

Checked commit pkliczewski@efaa339 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@pkliczewski
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@pkliczewski
Copy link
Contributor Author

@miq-bot assign @agrare

@agrare agrare merged commit b3c7633 into ManageIQ:master Jan 9, 2018
@agrare agrare added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 9, 2018
simaishi pushed a commit that referenced this pull request Jan 9, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2018

Gaprindashvili backport details:

$ git log -1
commit bf37ca57fca0a572c50d0526e63109e9e3b16eb4
Author: Adam Grare <[email protected]>
Date:   Tue Jan 9 09:25:45 2018 -0500

    Merge pull request #16767 from pkliczewski/reconnect
    
    Reconnect host on provider add
    (cherry picked from commit b3c7633ba07f369c6cc514d3b31b9fcbedca222c)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532332

@simaishi
Copy link
Contributor

@pkliczewski ManageIQ/manageiq-providers-ovirt#182 depends on this PR and is marked as fine/yes. Can this PR be fine/yes?

@pkliczewski
Copy link
Contributor Author

@simaishi The dependency is not there. I was my mistake to state it incorrectly. No need to mark this as fine\yes

@simaishi
Copy link
Contributor

@pkliczewski OK. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants