-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change aliases for container entities #16765
Conversation
@miq-bot add_label bug, provider/containers |
@nimrodshn perfect |
@nimrodshn Cannot apply the following label because they are not recognized: provider/containers |
@miq-bot add_label gaprindashvili/yes, providers/containers |
I think these 2 are missing?
(or do we not need to change these since they are unique?) and possibly |
Do I need to add |
@nimrodshn Agreed. |
changing more container entities
6ba47ee
to
7325314
Compare
Checked commit nimrodshn@7325314 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@blomquisg PTAL 😄 |
@blomquisg mind taking a look? 😇 |
Change aliases for container entities (cherry picked from commit 1271f84) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552266
Gaprindashvili backport details:
|
Currently there are a number of Container related entities who's aliases create confusion. (See
Node
vsHost / Node
in screenshot).This PR fixes this issue.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1513420
cc: @himdel @Loicavenel
Screenshot: