Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aliases for container entities #16765

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

nimrodshn
Copy link
Contributor

@nimrodshn nimrodshn commented Jan 8, 2018

Currently there are a number of Container related entities who's aliases create confusion. (See Node vs Host / Node in screenshot).

This PR fixes this issue.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1513420
cc: @himdel @Loicavenel

Screenshot:
host-node-issue

@nimrodshn
Copy link
Contributor Author

@miq-bot add_label bug, provider/containers

@Loicavenel
Copy link

@nimrodshn perfect

@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2018

@nimrodshn Cannot apply the following label because they are not recognized: provider/containers

@miq-bot miq-bot added the bug label Jan 8, 2018
@nimrodshn
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes, providers/containers

@himdel
Copy link
Contributor

himdel commented Jan 8, 2018

I think these 2 are missing?

        ContainerImageRegistry:   Image Registry
        ContainerReplicator:      Replicator

(or do we not need to change these since they are unique?)

and possibly ContainerProjectPerformance should translate to Performance - Container Project (missing space)

@nimrodshn
Copy link
Contributor Author

@Loicavenel @zeari @enoodle

I think these 2 are missing?

    ContainerImageRegistry:   Image Registry
    ContainerReplicator:      Replicator

(or do we not need to change these since they are unique?)

Do I need to add ContainerImageRegistry and/or ContainerReplicator

@Loicavenel
Copy link

@nimrodshn Agreed.

changing more container entities
@nimrodshn nimrodshn force-pushed the change_containernode_alias branch from 6ba47ee to 7325314 Compare January 10, 2018 11:44
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2018

Checked commit nimrodshn@7325314 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@nimrodshn
Copy link
Contributor Author

nimrodshn commented Jan 11, 2018

@blomquisg PTAL 😄

@nimrodshn
Copy link
Contributor Author

@blomquisg mind taking a look? 😇

@agrare agrare merged commit 1271f84 into ManageIQ:master Jan 25, 2018
@agrare agrare added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 25, 2018
simaishi pushed a commit that referenced this pull request Mar 6, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit b24b4d4e1419d68e6fcf31c09d1fb8b2938f445d
Author: Adam Grare <[email protected]>
Date:   Thu Jan 25 10:16:05 2018 -0500

    Merge pull request #16765 from nimrodshn/change_containernode_alias
    
    Change aliases for container entities
    (cherry picked from commit 1271f84ae863ccf5311475491f69d2ae87c4329b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants