Scope User and MiqGroup searches within the current region #16756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
scope_users_in_my_region
branch
from
9961b27 to
94cc845
Compare
gmcculloug
reviewed
Jan 5, 2018
app/models/user.rb
Outdated
| @@ -107,7 +107,7 @@ def validate | |||
| def current_group_by_description=(group_description) | |||
| if group_description | |||
| desired_group = miq_groups.detect { |g| g.description == group_description } | |||
| desired_group ||= MiqGroup.find_by(:description => group_description) if super_admin_user? | |||
| desired_group ||= MiqGroup.in_my_region.find_by(:description => group_description) if super_admin_user? | |||
There was a problem hiding this comment.
Does it make more sense for the find_by call to happen in the region of the user instead of just the current region?
@gtanzillo Any thoughts on this one?
bdunne
force-pushed
the
scope_users_in_my_region
branch
from
94cc845 to
faaf0f7
Compare
|
Checked commit bdunne@faaf0f7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
reviewed
Jan 5, 2018
| @@ -107,7 +107,7 @@ def validate | |||
| def current_group_by_description=(group_description) | |||
| if group_description | |||
| desired_group = miq_groups.detect { |g| g.description == group_description } | |||
| desired_group ||= MiqGroup.find_by(:description => group_description) if super_admin_user? | |||
| desired_group ||= MiqGroup.in_region(region_id).find_by(:description => group_description) if super_admin_user? | |||
There was a problem hiding this comment.
Is there a reason why you used in_region here instead of in_my_region?
|
@gtanzillo My initial comment is here #16756 (review). I suggested that the group should be scoped to the region of the user instead of the current region. |
gmcculloug
approved these changes
Jan 5, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 8, 2018
Scope User and MiqGroup searches within the current region (cherry picked from commit 57dac5a) https://bugzilla.redhat.com/show_bug.cgi?id=1532327
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Scope User and MiqGroup searches within the current region (cherry picked from commit 57dac5a) https://bugzilla.redhat.com/show_bug.cgi?id=1532328
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Scope User and MiqGroup searches within the current region (cherry picked from commit 57dac5a) https://bugzilla.redhat.com/show_bug.cgi?id=1532328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1529995