Log Decorator is required by VMDB::Loggers, but not in Gemfile #16751
Conversation
|
Whops forgot a comma |
juliancheal
force-pushed
the
adding_log_decorator_gem
branch
2 times, most recently
from
c170804 to
727a216
Compare
Thanks |
juliancheal
force-pushed
the
adding_log_decorator_gem
branch
from
727a216 to
1697e54
Compare
|
Ah that explains it. It's the difference between Gemfiles and Gemspec files. Where you can do |
Gemfile
Outdated
| @@ -41,6 +41,7 @@ gem "highline", "~>1.6.21", :require => false | |||
| gem "inifile", "~>3.0", :require => false | |||
| gem "kubeclient", "~>2.4.0", :require => false # For scaling pods at runtime | |||
| gem "linux_admin", "~>1.2.0", :require => false | |||
| gem 'log_decorator' "~>0.1", :require => false | |||
There was a problem hiding this comment.
For consistency can you use double-quotes?
There was a problem hiding this comment.
and a comma after log_decorator
There was a problem hiding this comment.
@Fryguy ah good point. Again I just took it from the other gem. Consistency everywhere!
|
Also, you are still missing a comma |
:'( oh my! |
It seems to only be required in Amazon SSA Support gem. Meaning if that gem isn't included ManageIQ doesn't run.
juliancheal
force-pushed
the
adding_log_decorator_gem
branch
from
1697e54 to
0ac8d73
Compare
|
Ok final try! Sorry team! |
|
Checked commit juliancheal@0ac8d73 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Extra u's, missing commas... what's next? |
|
@juliancheal can you check if this needs to be backported to gaprindashvili/fine at some point? |
It seems to only be required in Amazon SSA Support gem.
Meaning if that gem isn't included ManageIQ doesn't run.