Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: ESxi host does not exit maintenance mode. #16710

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

Imaanpreet
Copy link
Contributor

TODO: Need to write test cases for this

https://bugzilla.redhat.com/show_bug.cgi?id=1528210

TODO: Need to write test cases for this
@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2017

Checked commit Imaanpreet@08a073b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@chessbyte chessbyte self-assigned this Jan 5, 2018
@chessbyte chessbyte merged commit 7a37a8a into ManageIQ:master Jan 5, 2018
@chessbyte chessbyte added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018
simaishi pushed a commit that referenced this pull request Jan 5, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit 6dd1afe07d03850592ff5b0f4e443665063f3e92
Author: Oleg Barenboim <[email protected]>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531602

@simaishi
Copy link
Contributor

@agrare I assume this can be fine/yes?

@agrare
Copy link
Member

agrare commented Apr 13, 2018

@simaishi yes

simaishi pushed a commit that referenced this pull request Apr 16, 2018
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit df482362cd4950381cb5ed013d4defb9195f1116
Author: Oleg Barenboim <[email protected]>
Date:   Fri Jan 5 09:23:15 2018 -0500

    Merge pull request #16710 from Imaanpreet/validate_exit_maint_mode
    
    Fixed: ESxi host does not exit maintenance mode.
    (cherry picked from commit 7a37a8acbfd4d0620a788bb4200c143f97033cfa)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1568042

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…_mode

Fixed: ESxi host does not exit maintenance mode.
(cherry picked from commit 7a37a8a)

https://bugzilla.redhat.com/show_bug.cgi?id=1568042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants