Send IDs through exec_api_call as a regular param not a block #16708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this doesn't fix the BZ linked, it's the next problem that the customer will hit once the authentication error is fixed. |
|
Do we support multiple ids at this level or is it only ever 1 at a time? |
|
It's always one here. This code path is for forwarding instance methods to a remote region. There is another method for forwarding class methods. |
|
@Fryguy since you're here... I labeled it with |
carbonin
approved these changes
Dec 20, 2017
|
If we're going to backport this I think we should probably have a BZ for the actual issue this is solving. |
When sending them through an array in a block, the client calls the action on the collection with an array of IDs. Unfortunately this returns an Array of ManageIQ::API::Client::ActionResults and Arrays aren't currently an expected response for this caller, so it will raise: "Got unexpected API result object Array" Rather than dealing with the confusion of calling .first on the array, allow an ID to be passed in. https://bugzilla.redhat.com/show_bug.cgi?id=1526009 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1528339
bdunne
force-pushed
the
fix_api_array_response
branch
from
a53e101 to
1eca9a8
Compare
|
Checked commit bdunne@1eca9a8 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Send IDs through exec_api_call as a regular param not a block (cherry picked from commit 2d95d40) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530677
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Send IDs through exec_api_call as a regular param not a block (cherry picked from commit 2d95d40) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531177
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Send IDs through exec_api_call as a regular param not a block (cherry picked from commit 2d95d40) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending them through an array in a block, the client calls the action on the collection with an array of IDs. Unfortunately this returns an array of
ManageIQ::API::Client::ActionResults and arrays aren't currently an expected response for this caller, so it will raiseGot unexpected API result object ArrayRather than dealing with the confusion of calling .first on the array, allow an ID to be passed in.
https://bugzilla.redhat.com/show_bug.cgi?id=1526009
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1528339