Rescue migration error and update status #16705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
|
@miq-bot add_labels automate, fine/yes, gaprindashvili/yes |
|
@bzwei Looks good. |
gmcculloug
reviewed
Dec 21, 2017
app/models/vm_migrate_task.rb
Outdated
| vm.relocate(host, respool, datastore, nil, disk_transform) | ||
| end | ||
| rescue => err | ||
| update_and_notify_parent(:state => 'finished', :status => 'error', :message => "Failed. Reason(#{err.message})") |
There was a problem hiding this comment.
Minor but it would be more consistent for the message to use [ ] around the err.message.
:message => "Failed. Reason:[#{err.message}]")
|
@bzwei This PR looks good assuming that we can make |
bzwei
force-pushed
the
migrate_with_error
branch
from
f0b56cd to
377f422
Compare
|
Checked commit bzwei@377f422 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Dec 21, 2017
pkliczewski
approved these changes
Dec 21, 2017
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Rescue migration error and update status (cherry picked from commit 805e023)
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Rescue migration error and update status (cherry picked from commit 805e023) https://bugzilla.redhat.com/show_bug.cgi?id=1478518
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Rescue migration error and update status (cherry picked from commit 805e023) https://bugzilla.redhat.com/show_bug.cgi?id=1478518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1448023
vm_migrate_task needs to rescue migration error and finish with error.
VMWare migration already raises error when a problem is detected. We just need to rescue it in the task.
RHV migration needs to enhance to monitor the migration status and raise error accordingly. The enhancement will be done in manageiq-providers-ovirt.