Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable mwPolicies" #16701

Merged
merged 1 commit into from
Dec 26, 2017
Merged

Revert "Enable mwPolicies" #16701

merged 1 commit into from
Dec 26, 2017

Conversation

karelhala
Copy link
Contributor

Reverts #16312

@karelhala
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes, middleware
@miq-bot assign @martinpovolny
@ManageIQ/core-hawkular please review
@martinpovolny since you merged #16312 can you please merge this one as well?

1 similar comment
@karelhala
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes, middleware
@miq-bot assign @martinpovolny
@ManageIQ/core-hawkular please review
@martinpovolny since you merged #16312 can you please merge this one as well?

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

@karelhala Cannot apply the following label because they are not recognized: middleware

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

@karelhala Cannot apply the following label because they are not recognized: middleware

tumido
tumido reviewed Dec 20, 2017
View reviewed changes
Copy link
Member

@tumido tumido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to remove this line 123 as well.

@xeviknal
Copy link
Member

+1 to @tumido and 😢

@israel-hdez
Copy link
Member

@tumido has a good catch.

@karelhala karelhala force-pushed the revert-16312-mwPolicies branch from d286d97 to 1ce1e33 Compare December 21, 2017 13:24
@karelhala
Copy link
Contributor Author

All gone @tumido good catch.

@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2017

Checked commit karelhala@1ce1e33 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@abonas
Copy link
Member

abonas commented Dec 21, 2017

@miq-bot rm_label bug

@abonas
Copy link
Member

abonas commented Dec 21, 2017

@miq-bot add_label providers/middleware

@martinpovolny martinpovolny merged commit ed4af9d into ManageIQ:master Dec 26, 2017
@martinpovolny martinpovolny added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 26, 2017
@cfcosta cfcosta mentioned this pull request Jan 2, 2018
Merged
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@martinpovolny @simaishi
Merge pull request #16701 from karelhala/revert-16312-mwPolicies
0f3b3dd 
Revert "Enable mwPolicies"
(cherry picked from commit ed4af9d)
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 0f3b3dddc1d2d8164619b3f56d128d356f73bd47
Author: Martin Povolny <[email protected]>
Date:   Tue Dec 26 18:04:09 2017 +0100

    Merge pull request #16701 from karelhala/revert-16312-mwPolicies
    
    Revert "Enable mwPolicies"
    (cherry picked from commit ed4af9d204e4178fc11f31ec5b47782118068ed8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido left review comments

@israel-hdez israel-hdez israel-hdez approved these changes

Assignees

@martinpovolny martinpovolny

Labels
gaprindashvili/backported providers/middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@karelhala @miq-bot @xeviknal @israel-hdez @abonas @simaishi @tumido @martinpovolny