Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide by default the Middleware tab in UI #16698

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Hide by default the Middleware tab in UI #16698

merged 1 commit into from
Dec 21, 2017

Conversation

abonas
Copy link
Member

@abonas abonas commented Dec 20, 2017 •
edited
Loading

per BZ 1526791, there is a need to hide the Middleware UI from miq
(this is a first PR in a series of PRs that handles this for misc screens)
before:
withmw

after
nomw

can be tested with mv permissions.tmpl.yml permissions.yml (and restarting miq)

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017 •
edited
Loading

@miq-bot add_label providers/middleware
@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

@abonas Cannot apply the following label because they are not recognized: garpindashvili/yes

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit abonas@1f9333b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017

@ManageIQ/core-hawkular fyi. please review

aljesusg
aljesusg approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@abonas
Copy link
Member Author

abonas commented Dec 20, 2017

@chessbyte @agrare @ohadlevy fyi

tumido
tumido approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare self-assigned this Dec 21, 2017
@agrare agrare added the blocker label Dec 21, 2017
agrare
agrare approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit aa91fd2 into ManageIQ:master Dec 21, 2017
@agrare agrare added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@israel-hdez israel-hdez mentioned this pull request Dec 27, 2017
Merged
@cfcosta cfcosta mentioned this pull request Jan 2, 2018
Merged
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@agrare @simaishi
Merge pull request #16698 from abonas/hideMiddlewareTabInUI
81d79e6 
Hide by default the Middleware tab in UI
(cherry picked from commit aa91fd2)
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 81d79e68d2f4d7a19e11cbe166351a8297d71dea
Author: Adam Grare <[email protected]>
Date:   Thu Dec 21 09:12:29 2017 -0500

    Merge pull request #16698 from abonas/hideMiddlewareTabInUI
    
    Hide by default the Middleware tab in UI
    (cherry picked from commit aa91fd2090b80a2d19135906ac5d08c173d68069)

@simaishi simaishi mentioned this pull request Jan 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@israel-hdez israel-hdez israel-hdez approved these changes

@agrare agrare agrare approved these changes

@tumido tumido tumido approved these changes

@karelhala karelhala karelhala approved these changes

@aljesusg aljesusg aljesusg approved these changes

@cfcosta cfcosta cfcosta approved these changes

Assignees

@agrare agrare

Labels
blocker gaprindashvili/backported providers/middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abonas @miq-bot @simaishi @cfcosta @aljesusg @karelhala @tumido @agrare @israel-hdez