Stop generating vim_performance_tag_values rows
#16692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit gtanzillo@266003d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
changed the title
vim_performance_tage_values rowsvim_performance_tage_values rows
gtanzillo
changed the title
vim_performance_tage_values rowsvim_performance_tag_values rows
Fryguy
reviewed
Jan 2, 2018
| @@ -97,7 +97,6 @@ def perf_rollup(time, interval_name, time_profile = nil) | |||
| end | |||
|
|
|||
| Benchmark.realtime_block(:db_update_perf) { perf.update_attributes(new_perf) } | |||
| Benchmark.realtime_block(:process_perfs_tag) { VimPerformanceTagValue.build_from_performance_record(perf) } | |||
There was a problem hiding this comment.
@kbrock You're going to like this one ;)
gtanzillo
force-pushed
the
dont-generate-tage-values
branch
from
266003d to
a9e3455
Compare
|
I like the direction this PR is going. 👍 |
gtanzillo
force-pushed
the
dont-generate-tage-values
branch
from
a9e3455 to
d0bc336
Compare
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Jan 2, 2018
Follow up to ManageIQ#16692 This change removes all the code involved with reading vim_performance_tag_values data from the table. It no longer necessary because it all generated on demand.
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Jan 2, 2018
Follow up to ManageIQ#16692 This change removes all the code involved with reading vim_performance_tag_values data from the table. It no longer necessary because it all generated on demand.
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Stop generating `vim_performance_tag_values` rows (cherry picked from commit 2c1b7a4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1512705 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530713
|
Gaprindashvili backport details: |
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 15, 2018
Follow up to ManageIQ#16692 This change removes all the code involved with reading vim_performance_tag_values data from the table. It no longer necessary because it all generated on demand.
gtanzillo
added a commit
to gtanzillo/manageiq
that referenced
this pull request
Mar 15, 2018
Follow up to ManageIQ#16692 This change removes all the code involved with reading vim_performance_tag_values data from the table. It no longer necessary because it all generated on demand.
JakubKubista
pushed a commit
to JakubKubista/manageiq
that referenced
this pull request
Apr 12, 2018
Follow up to ManageIQ#16692 This change removes all the code involved with reading vim_performance_tag_values data from the table. It no longer necessary because it all generated on demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #16582 where
vim_performance_tagsare generated on the fly instead of read from the table. Once that PR is merged, there will be no need to continue to generate and persist this tag values during performance processing.This will eliminate huge database sizes that persisting this data causes. Once this is merged we should be able to removed the table altogether. That can be done in a different PR.
/cc @carbonin @Fryguy
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1510484
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1514505