Use UUID to ensure the uniqueness of job template name #16672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
force-pushed
the
unique_jt_name
branch
from
715147d to
564d891
Compare
gmcculloug
reviewed
Dec 18, 2017
| end | ||
|
|
||
| private | ||
|
|
||
| def build_parameter_list(options) | ||
| params = { | ||
| :name => options[:template_name] || "#{name}_#{Time.zone.now.to_i}", | ||
| :name => options[:template_name] || "#{name}_#{SecureRandom.uuid}", |
There was a problem hiding this comment.
@bzwei I like this change. Thinking we should add the time to the description so we have a reference if needed.
bzwei
force-pushed
the
unique_jt_name
branch
from
564d891 to
1906989
Compare
|
Checked commit bzwei@1906989 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
approved these changes
Dec 18, 2017
syncrou
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
This looks great to me. I like the time stamp for the description ( as suggested by @gmcculloug )
simaishi
pushed a commit
that referenced
this pull request
Dec 19, 2017
Use UUID to ensure the uniqueness of job template name (cherry picked from commit 80c69ec) https://bugzilla.redhat.com/show_bug.cgi?id=1527560
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create job template (and inventory) to run a playbook, a timestamp was appended to the name to ensure the name uniqueness at the tower side. For the setup reported in the BZ after multiple VM provisioning completed they all tried to run the same playbook at the same second, causing a naming collision.
The solution is to replace the timestamp with a UUID.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525683