remove satellite6 credential type from embedded ansible space

[jameswnl]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525172

Depends on ManageIQ/manageiq-providers-ansible_tower#46

After deploying both PR, I added an external Tower and refresh will still inventory the Satellite6Credential as follow db output,

vmdb_production=# select name, type, resource_type, resource_id from authentications where type like '%Satellite%';
      name      |                                    type                                    |    resource_type    | resource_id
----------------+----------------------------------------------------------------------------+---------------------+-------------
 hello_sat_cred | ManageIQ::Providers::AnsibleTower::AutomationManager::Satellite6Credential | ExtManagementSystem |           5
 sat6_cred      | ManageIQ::Providers::AnsibleTower::AutomationManager::Satellite6Credential | ExtManagementSystem |           5
(2 rows)

And at the same time, Satellite6Credential type is gone from embedded one as shown here

[jameswnl]

@miq-bot add_labels bug, blocker, providers/ansible_tower

[blomquisg]

@jameswnl can you add a screenshot that shows the Sat6 credential removed from the list for embedded ansible?

[blomquisg]

LGTM ... the tower pr 46 is still being reviewed, but I think this one is good once that's merged.

@gmcculloug

[jameswnl]

too graphic this review has become...

[gmcculloug]

@blomquisg It's everything I dreamed it would be. 👍

Is the failing test because of the related PR or a change required here?

[blomquisg]

Is the failing test because of the related PR or a change required here?

Yep. Once that's merged, I believe this should pass.

[miq-bot]

Checked commit jameswnl@07f6bd3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit e3dea29b5b31cfda2dd1c1f5e810ed37c30095d7
Author: Adam Grare <[email protected]>
Date:   Tue Dec 19 09:35:21 2017 -0500

    Merge pull request #16663 from jameswnl/hide-sat6
    
    remove satellite6 credential type from embedded ansible space
    (cherry picked from commit a649e48674a1b0302732c6dbe653ab77209163c8)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527583