Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog label has been deprecated #16657

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Dialog label has been deprecated #16657

merged 1 commit into from
Dec 13, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Dec 13, 2017

Dialog label made more sense as name and this is the mere start of updating the callers

@d-m-u
Copy link
Contributor Author

d-m-u commented Dec 13, 2017 •
edited
Loading

@bdunne hi! :)

@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2017

Checked commit d-m-u@8510e44 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@bdunne bdunne merged commit aa6336d into ManageIQ:master Dec 13, 2017
@bdunne bdunne self-assigned this Dec 13, 2017
@bdunne bdunne added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 13, 2017
@d-m-u d-m-u deleted the updating_dialog_label_to_name_in_that_one_place_for_daily_stats branch December 13, 2017 17:23
simaishi pushed a commit that referenced this pull request Dec 14, 2017
@bdunne @simaishi
Merge pull request #16657 from d-m-u/updating_dialog_label_to_name_in…
8d5d89b 
…_that_one_place_for_daily_stats

Dialog label has been deprecated
(cherry picked from commit aa6336d)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 8d5d89b26f0005e25caa62d92391d2f045424f2a
Author: Brandon Dunne <[email protected]>
Date:   Wed Dec 13 12:12:59 2017 -0500

    Merge pull request #16657 from d-m-u/updating_dialog_label_to_name_in_that_one_place_for_daily_stats
    
    Dialog label has been deprecated
    (cherry picked from commit aa6336d78685c0a45451858f11234513c8a009cc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdunne bdunne

Labels
gaprindashvili/backported lifecycle/services technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @miq-bot @simaishi @bdunne