Removed redundant "Monitor" main tab node. #16648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an extra node that was causing confusion on role edit/summary screen while showing the node and it's children as selected even tho it was selected and user had an access to Monitor main tab in UI. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1514279
|
Checked commit h-kataria@239e165 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria I think this might conflict with the Control Alerts area, let's discuss offline. |
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2017
Removed redundant "Monitor" main tab node. (cherry picked from commit 5b2e1b8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526047
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an extra node that was causing confusion on role edit/summary screen while showing the node and it's children as selected even tho it was selected and user had an access to Monitor main tab in UI.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1514279
@dclarizio @martinpovolny please review.
before fix, when i unselected "Control" after saving role, role summary and role edit screens showed "Monitor" as unselected as well, even tho when logging in with the new role, i could see/access Monitor menu.
after, display correct selections:
