Fix error in timeout checking for job without target #16627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute was not initialized
yrudman
force-pushed
the
fix-error-in-timeout-checking-for-job-without-target
branch
from
f77cc85 to
7d0c95d
Compare
|
Checked commits yrudman/manageiq@b67e12f~...7d0c95d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 Looks good, helps us debug problems |
|
@gtanzillo could you review |
gtanzillo
approved these changes
Dec 11, 2017
yrudman
deleted the
fix-error-in-timeout-checking-for-job-without-target
branch
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…for-job-without-target Fix error in timeout checking for job without target (cherry picked from commit 5729359) https://bugzilla.redhat.com/show_bug.cgi?id=1524592
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Original design for
Jobmodel assumed thattarget_classattribute always initialized.If job created without initialization of
target_class(running Ansible Playbook methods, or creating some other job which does not require target) than this error thrown when checking if job timed-out:[----] E, [2017-12-07T10:42:36.205262 #36948:d39140] ERROR -- : MIQ(Job.check_jobs_for_timeout) undefined methodconstantize' for nil:NilClass`BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1523320
Solution:
create instance of target (to retrieve target specific timeout adjustment) only if
target_classis notnil@miq-bot add-label bug, core, gaprindashvili/yes
\cc @mkanoor