EmsRefresh task name to use demodularize classname #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_labels providers |
jameswnl
force-pushed
the
task-name
branch
2 times, most recently
from
1764b81 to
2fccd5b
Compare
jameswnl
commented
Dec 5, 2017
| describe ".create_refresh_task" do | ||
| it "create refresh task and trancates task name to 255 symbols" do | ||
| vm = FactoryGirl.create(:vm_vmware, :name => "vm_vmware1", :ext_management_system => @ems) | ||
| targets = Array.new(500) { vm } |
There was a problem hiding this comment.
This has been wrong
|
@miq-bot add_label bug |
agrare
reviewed
Dec 12, 2017
app/models/ems_refresh.rb
Outdated
| @@ -204,6 +204,9 @@ def self.queue_merge(targets, ems, create_task = false) | |||
| end | |||
|
|
|||
| def self.create_refresh_task(ems, targets) | |||
| targets = targets.collect do |t| | |||
| [t.first.demodulize, t.last] | |||
There was a problem hiding this comment.
Can you change this to
targets.collect do |target_class, target_id|
So you don't need to do t.first/t.last?
|
Checked commit jameswnl@2d7e450 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1503660
It used to be like
EmsRefresh(ems_0000000000001) [[["ManageIQ::Providers::Vmware::InfraManager::Vm", 30], ["ManageIQ::Providers::Vmware::InfraManager::Vm", 31]]]and now it will be
EmsRefresh(ems_0000000000001) [[["Vm", 30], ["Vm", 31]]]