Fix cached query for total unregistered vms

[lpichler]

Storage#total_unregistered_vms and Storage#unregistered_vms are using different queries.

Query here is not same as it is here (method registered? on VM: Vm#registered? )

@kbrock can you please review? (you touched this code last time )

🎁 @ZitaNemeckova

@miq-bot add_label bug, core

@miq-bot assign @gtanzillo

[miq-bot]

@lpichler Cannot apply the following label because they are not recognized: gapridashivili/yes

[lpichler]

@miq-bot add_label gaprindashivili/yes

[miq-bot]

@lpichler Cannot apply the following label because they are not recognized: gaprindashivili/yes

[ZitaNemeckova]

@miq-bot add_label gaprindashvili/yes

[miq-bot]

@lpichler Cannot apply the following label because they are not recognized: gaprindashivili/yes

[kbrock]

Good eye.

1. I even wonder if registered? is right
2. Do we mean to be running from the Vm Or should we be pointing to VmOrTemplate? If we want just Vm, then we know template? == false.

The logic: Templates must have an EMS, but all others just need a host.
So if you are looking at VMs, then you only need to ask if a host_id is present.

class VmOrTemplate
  def registered?
    return false if self.template? && ext_management_system_id.nil?
    host_id.present?
  end
end

If we are querying Vm then we know that template? == false.
So the clause becomes:

class VmOrTemplate
  def registered?
    host_id.present?
  end
end

So unregistered becomes:

cache_with_timeout(:unregistered_vm_counts_by_storage_id, 15.seconds) do
  Vm.not(:host_id => nil)
  .group("storage_id").pluck("storage_id, COUNT(*) AS vm_count")
  .each_with_object(Hash.new(0)) { |(storage_id, count), h| h[storage_id] = count.to_i }
end

Also fun. (sorry) Think the pluck can just be a count:

cache_with_timeout(:unregistered_vm_counts_by_storage_id, 15.seconds) do
  Vm.not(:host_id => nil).group("storage_id").count
  .each_with_object(Hash.new(0)) { |(storage_id, count), h| h[storage_id] = count.to_i }
end

[lpichler]

yes, that's right, awesome, thanks ! I filtered out also vms without storages because to use this method we need always existing storage - so it was useless.

[miq-bot]

Checked commits lpichler/manageiq@aef94e9~...9863192 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 38b2460ae95c62108988bc6453294f1e18d39e94
Author: Keenan Brock <[email protected]>
Date:   Tue Dec 5 13:25:21 2017 -0500

    Merge pull request #16577 from lpichler/fix_cached_query_total_registered_vms
    
    Fix cached query for total unregistered vms
    (cherry picked from commit 3ebe6ccd94262f3d05a43a05aded8254622bfd09)